smengcl commented on code in PR #4819:
URL: https://github.com/apache/ozone/pull/4819#discussion_r1232934673
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -623,20 +689,29 @@ private synchronized SnapshotDiffJob
getSnapDiffReportStatus(
return snapDiffJob;
}
- private void validateSnapshotsAreActive(final String volumeName,
- final String bucketName,
- final String fromSnapshotName,
- final String toSnapshotName)
+ private boolean validateDiffJobAndSnapshotsAreActive(
Review Comment:
```suggestion
private boolean areDiffJobAndSnapshotsActive(
```
since it returns `boolean` now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
