smengcl commented on code in PR #4819:
URL: https://github.com/apache/ozone/pull/4819#discussion_r1232933566
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -418,6 +478,12 @@ public SnapshotDiffResponse getSnapshotDiffReport(
bucketName, fromSnapshotName, toSnapshotName, new ArrayList<>(),
null),
REJECTED, defaultWaitTime);
+ case CANCELED:
+ return new SnapshotDiffResponse(
+ new SnapshotDiffReportOzone(snapshotRoot.toString(), volumeName,
+ bucketName, fromSnapshotName, toSnapshotName, new ArrayList<>(),
+ null),
+ CANCELED, 0L, CancelStatus.CANCEL_SUCCESS);
Review Comment:
Unrelated to this PR but I think `SnapshotDiffReportOzone` could use a
`Builder` subclass. cc @hemantk-12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
