GeorgeJahad commented on code in PR #5070:
URL: https://github.com/apache/ozone/pull/5070#discussion_r1264214134
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -588,6 +590,8 @@ public void onCompactionCompleted(RocksDB db,
return;
}
+ waitForTarballCreation();
Review Comment:
Waiting like this is probably not safe. The doc for the
onCompactionCompleted() listeners advises against doing it:
"Note that this function must be implemented in a way such that it should
not run for an extended period of time before the function returns. Otherwise,
RocksDB may be blocked."
https://javadoc.io/static/org.rocksdb/rocksdbjni/7.3.1/org/rocksdb/AbstractEventListener.html#onCompactionCompleted-org.rocksdb.RocksDB-org.rocksdb.CompactionJobInfo-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
