GeorgeJahad commented on code in PR #5070:
URL: https://github.com/apache/ozone/pull/5070#discussion_r1264224444
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -588,6 +590,8 @@ public void onCompactionCompleted(RocksDB db,
return;
}
+ waitForTarballCreation();
Review Comment:
Maybe there is a better way. The transaction logs have the seq number in
the name, right?
if we could start a new compaction log when the tarball creation starts,
then tarball creation process could look at the file names and skip copying
over logs whose name indicate a transaction number that is too large for the
checkpoint in this tarball. Would that work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
