hemantk-12 commented on code in PR #5070:
URL: https://github.com/apache/ozone/pull/5070#discussion_r1264230191
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -588,6 +590,8 @@ public void onCompactionCompleted(RocksDB db,
return;
}
+ waitForTarballCreation();
Review Comment:
Just transaction seq number in log doesn't solve the problem. I tired to
explain it here:
[8db58df](https://github.com/apache/ozone/commit/8db58df12318108b2d4e3cf8dc9bfeaccc4fadbe#diff-1d5c6c892a2d24d85ca002dafcb9f39341192baaa7b5323d2325b5fc7a238c7f)
and wrote a [coding using
ThreadLocal](https://github.com/apache/ozone/commit/8db58df12318108b2d4e3cf8dc9bfeaccc4fadbe#diff-1d5c6c892a2d24d85ca002dafcb9f39341192baaa7b5323d2325b5fc7a238c7fR500)
But problem with above is that assumption that CompactionBeginListener and
CompactionCompletedListener are running on a same thread is wrong itself.
The only way to solve these issues it to pause and resume the compaction.
Pausing is using `RocksDB#pauseBackgroundWork` this has its own complications.
Hence we are going with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
