hemantk-12 commented on code in PR #5139:
URL: https://github.com/apache/ozone/pull/5139#discussion_r1282410673
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBCheckpointUtils.java:
##########
@@ -67,4 +68,15 @@ public static boolean waitForCheckpointDirectoryExist(File
file)
return false;
}
}
+
+ /**
+ * Wait for checkpoint directory to be created for 5 secs with 100 millis
+ * poll interval.
+ * @param file Checkpoint directory.
+ * @return true if found.
+ */
+ public static boolean waitForCheckpointDirectoryExist(File file)
Review Comment:
This is use by [bootstrapping
code](https://github.com/apache/ozone/blob/6113470e667f31955d4a044a56871c21bbe591de/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java#L247).
Not sure if we need to change `waitForCheckpointDirectoryExist(File file)` to
`waitForCheckpointDirectoryExist(File file, Duration timeout)` in bootstrapping?
My understanding is that doublebuffer must have flushed by the time we are
here. Please double checked to make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
