swamirishi commented on code in PR #5139:
URL: https://github.com/apache/ozone/pull/5139#discussion_r1282639266


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java:
##########
@@ -101,7 +102,7 @@ public static void checkSnapshotDirExist(File checkpoint)
     if (!checkpoint.exists()) {
       throw new OMException("Unable to load snapshot. " +
           "Snapshot checkpoint directory '" + checkpoint.getAbsolutePath() +
-          "' does not exists.", FILE_NOT_FOUND);
+          "' does not exists.", TIMEOUT);

Review Comment:
   done



##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBCheckpointUtils.java:
##########
@@ -45,13 +45,14 @@ private RDBCheckpointUtils() { }
    * Wait for checkpoint directory to be created for 5 secs with 100 millis
    * poll interval.
    * @param file Checkpoint directory.
+   * @param pollMaxDuration max duration for polling
    * @return true if found.
    */
-  public static boolean waitForCheckpointDirectoryExist(File file)
-      throws IOException {
+  public static boolean waitForCheckpointDirectoryExist(File file,
+         Duration pollMaxDuration) {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to