hemantk-12 commented on code in PR #5139:
URL: https://github.com/apache/ozone/pull/5139#discussion_r1282503289
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBCheckpointUtils.java:
##########
@@ -42,16 +42,17 @@ public final class RDBCheckpointUtils {
private RDBCheckpointUtils() { }
/**
- * Wait for checkpoint directory to be created for 5 secs with 100 millis
+ * Wait for checkpoint directory to be created with 100 millis
* poll interval.
* @param file Checkpoint directory.
+ * @param pollMaxDuration max duration for polling
* @return true if found.
*/
- public static boolean waitForCheckpointDirectoryExist(File file)
- throws IOException {
+ public static boolean waitForCheckpointDirectoryExist(File file,
+ Duration pollMaxDuration) {
Review Comment:
nit:
```suggestion
Duration maxWaitTimeout) {
```
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBCheckpointUtils.java:
##########
@@ -42,16 +42,17 @@ public final class RDBCheckpointUtils {
private RDBCheckpointUtils() { }
/**
- * Wait for checkpoint directory to be created for 5 secs with 100 millis
+ * Wait for checkpoint directory to be created with 100 millis
Review Comment:
nit:
```suggestion
* Wait for checkpoint directory to be created for the given duration with
100 millis
* poll interval.
* @param file Checkpoint directory.
* @param maxWaitTimeout wait at most before request timeout and returns
false.
* @return true if found within given timeout.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
