swamirishi commented on code in PR #5165:
URL: https://github.com/apache/ozone/pull/5165#discussion_r1309320265
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java:
##########
@@ -91,19 +91,24 @@ private Map<String, Integer> createKeys(int startRange, int
endRange) {
i -> i % 2));
}
- private Pair<Map<String, Integer>, List<String>> createDummyData(
+ private Pair<TreeMap<String, Integer>, List<String>> createDummyData(
Review Comment:
Changed it to SortedMap, getTestingBounds function needs SortedMap as an
argument.
##########
hadoop-hdds/test-utils/src/main/java/org/apache/ozone/test/GenericTestUtils.java:
##########
@@ -464,4 +469,34 @@ public void write(byte[] buf, int off, int len) {
}
}
+ public static String getLexicographicallyLowerString(String val) {
+ char[] charVal = val.toCharArray();
+ charVal[charVal.length - 1] -= 1;
+ return String.valueOf(charVal);
+ }
+
+ public static String getLexicographicallyHigherString(String val) {
+ char[] charVal = val.toCharArray();
+ charVal[charVal.length - 1] += 1;
+ return String.valueOf(charVal);
+ }
+
+ public static List<Optional<String>> getTestingBounds(
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
