swamirishi commented on code in PR #5165:
URL: https://github.com/apache/ozone/pull/5165#discussion_r1293906282
##########
hadoop-hdds/rocks-native/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedSSTDumpIterator.java:
##########
@@ -126,11 +135,18 @@ private Optional<UnsignedLong> getNextUnsignedLong()
throws IOException {
}
private void init(ManagedSSTDumpTool sstDumpTool, File sstFile,
- ManagedOptions options)
+ ManagedOptions options, Optional<ManagedSlice> lowerKeyBound,
+ Optional<ManagedSlice> upperKeyBound)
throws NativeLibraryNotLoadedException {
- String[] args = {"--file=" + sstFile.getAbsolutePath(), "--command=scan",
- "--silent"};
- this.sstDumpToolTask = sstDumpTool.run(args, options);
+ Map<String, String> argMap = Maps.newHashMap();
+ argMap.put("file", sstFile.getAbsolutePath());
+ argMap.put("silent", null);
Review Comment:
Without --silent adds some unwanted logs in SSTDumpTool. It should have a
value. You can look at ManagedSSTDumpTool class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
