swamirishi commented on code in PR #5303:
URL: https://github.com/apache/ozone/pull/5303#discussion_r1327851516
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -479,4 +479,19 @@ message DeletedBlocksTransactionInfo {
optional int64 containerID = 2;
repeated int64 localID = 3;
optional int32 count = 4;
-}
\ No newline at end of file
+}
+
Review Comment:
Can we have sub proto with both start key and end key put together? Either
this node has both values or none?
```suggestion
message FileInfoRange {
required string startKey = 2;
required string endKey = 3;
}
message CompactionFileInfoProto {
required string fileName = 1;
optional FileInfoRange range = 2;
optional string columnFamily = 3;
}
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -247,7 +250,8 @@ public class OmMetadataManagerImpl implements
OMMetadataManager,
PRINCIPAL_TO_ACCESS_IDS_TABLE,
TENANT_STATE_TABLE,
SNAPSHOT_INFO_TABLE,
- SNAPSHOT_RENAMED_TABLE
+ SNAPSHOT_RENAMED_TABLE,
+ COMPACTION_LOG_TABLE
Review Comment:
Can you add the table in the comments. With key and value format
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/CompactionFileInfo.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ozone.compaction.log;
+
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
+
+/**
+ * Dao to keep SST file information in the compaction log.
+ */
+public class CompactionFileInfo {
+ private final String fileName;
+ private final String startKey;
Review Comment:
Similar change as suggested in proto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
