hemantk-12 commented on code in PR #5303:
URL: https://github.com/apache/ozone/pull/5303#discussion_r1327877124
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -479,4 +479,19 @@ message DeletedBlocksTransactionInfo {
optional int64 containerID = 2;
repeated int64 localID = 3;
optional int32 count = 4;
-}
\ No newline at end of file
+}
+
Review Comment:
If any of `startKey`, `endKey` and `columnFamily` is null, we should not be
using it to filter the DAG because if `columnFamily` is null, `startKey` and
`endKey` doesn't matter.
Something similar to
https://github.com/apache/ozone/pull/5236/files#diff-1d5c6c892a2d24d85ca002dafcb9f39341192baaa7b5323d2325b5fc7a238c7fR1598
So basically it should be on the caller of `CompactionFileInfo` and decide
how to handle null case scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
