sadanand48 commented on PR #5445: URL: https://github.com/apache/ozone/pull/5445#issuecomment-1766006176
Thanks @ArafatKhan2198 for the patch & @Pochatkin for the comment. I think we should make the cache unbounded i.e it should not invalidate an entry based on size or expiry time . The invalidation should only happen during OM double buffer flush. I'm not exactly sure about the rationale behind using guava cache, Using RocksDb Table cache could have avoided these issues . @ArafatKhan2198 We should add the logic to invalidate cache (delete entries) during Double Buffer flush which is not there currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
