hemantk-12 commented on code in PR #5511:
URL: https://github.com/apache/ozone/pull/5511#discussion_r1376870410
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -188,6 +178,8 @@ public class RocksDBCheckpointDiffer implements
AutoCloseable,
private ColumnFamilyHandle compactionLogTableCFHandle;
private RocksDB activeRocksDB;
+ public static final Set<String> COLUMN_FAMILIES_TO_TRACK_IN_DAG =
+ ImmutableSet.of("keyTable", "directoryTable", "fileTable");
Review Comment:
Problem with that is cyclic dependency. Currently `columnFamilies` are
defined in ozone-manager and `ozone-manager` depends on
`rocksdb-checkpoint-differ`. If we use predefined constants from
`ozone-manager`, it will create cyclic dependency between `ozone-manager` and
`rocksdb-checkpoint-differ`
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -188,6 +178,8 @@ public class RocksDBCheckpointDiffer implements
AutoCloseable,
private ColumnFamilyHandle compactionLogTableCFHandle;
private RocksDB activeRocksDB;
+ public static final Set<String> COLUMN_FAMILIES_TO_TRACK_IN_DAG =
+ ImmutableSet.of("keyTable", "directoryTable", "fileTable");
Review Comment:
Problem with that is cyclic dependency. Currently `columnFamilies` are
defined in ozone-manager and `ozone-manager` depends on
`rocksdb-checkpoint-differ`. If we use predefined constants from
`ozone-manager`, it will create cyclic dependency between `ozone-manager` and
`rocksdb-checkpoint-differ`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
