hemantk-12 commented on code in PR #5511:
URL: https://github.com/apache/ozone/pull/5511#discussion_r1389102929
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -455,9 +447,6 @@ public void onCompactionBegin(RocksDB db,
return;
}
Review Comment:
It is a great point. Thank you for the suggestion.
Removed individual `shouldSkipFile()` check and added early return in
compactionListeners if compaction job doesn't belong to desired column family.
Added `shouldSkipCompaction()` function and tests for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
