hemantk-12 commented on code in PR #5511:
URL: https://github.com/apache/ozone/pull/5511#discussion_r1396025945
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -445,19 +442,42 @@ private boolean isSnapshotInfoTableEmpty(RocksDB db) {
}
}
+ @VisibleForTesting
+ boolean shouldSkipCompaction(byte[] columnFamilyBytes,
+ List<String> inputFiles,
+ List<String> outputFiles) {
+ String columnFamily = StringUtils.bytes2String(columnFamilyBytes);
+
+ if (!COLUMN_FAMILIES_TO_TRACK_IN_DAG.contains(columnFamily)) {
+ LOG.debug("Skipping compaction for columnFamily: {}", columnFamily);
+ return true;
+ }
+
+ if (inputFiles.isEmpty()) {
+ LOG.debug("Compaction input files list is empty");
+ return true;
+ }
+
+ if (new HashSet<>(inputFiles).equals(new HashSet<>(outputFiles))) {
Review Comment:
Yes, it is. We have seen bug caused by this and we were going infinite loop
due to self arc.
https://issues.apache.org/jira/browse/HDDS-8160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
