sadanand48 commented on code in PR #5445:
URL: https://github.com/apache/ozone/pull/5445#discussion_r1396783038
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -732,12 +735,14 @@ public OpenKeySession openKey(OmKeyArgs args) throws
IOException {
private OMResponse handleError(OMResponse resp) throws OMException {
if (resp.getStatus() != OK) {
+ LOG.error("OMException occurred: {}", resp.getMessage());
throw new OMException(resp.getMessage(),
ResultCodes.values()[resp.getStatus().ordinal()]);
}
return resp;
}
+
Review Comment:
remove extra new line
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestSecureOzoneCluster.java:
##########
@@ -1414,7 +1414,7 @@ private static X509CertificateHolder
generateX509CertHolder(
.setSubject(subject)
.setDigitalSignature(true)
.setDigitalEncryption(true);
-
+
Review Comment:
+1
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3SecretManagerImpl.java:
##########
@@ -118,4 +129,11 @@ public S3SecretCache cache() {
public S3Batcher batcher() {
return s3SecretStore.batcher();
}
+
+ public void updateCache(String kerberosID, S3SecretValue secret) {
+ S3SecretManager.super.updateCache(kerberosID, secret);
+ }
+
+
+
Review Comment:
remove extra new lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
