sadanand48 commented on code in PR #5445:
URL: https://github.com/apache/ozone/pull/5445#discussion_r1379763234
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -285,6 +295,8 @@ private void addToBatchTransactionInfoWithTrace(String
parentName,
void flushTransactions() {
while (isRunning.get() && canFlush()) {
flushCurrentBuffer();
+ // Invalidate all the content in S3SecretManager cache.
+ s3SecretManager.clearS3Cache();
Review Comment:
```java
buffer.iterator().forEachRemaining(
entry -> addCleanupEntry(entry, cleanupEpochs));
```
Let's say there were entries added to the buffer after this line, In that
case we cannot cleanup all entries in cache as cache might contain entries that
have not yet been considered for flush in the batch. To solve this we maintain
cleanup epochs and only delete those particular entries for cleanup from cache
that have been flushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
