ArafatKhan2198 commented on code in PR #5445:
URL: https://github.com/apache/ozone/pull/5445#discussion_r1379744944


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -285,6 +295,8 @@ private void addToBatchTransactionInfoWithTrace(String 
parentName,
   void flushTransactions() {
     while (isRunning.get() && canFlush()) {
       flushCurrentBuffer();
+      // Invalidate all the content in S3SecretManager cache.
+      s3SecretManager.clearS3Cache();

Review Comment:
   Thanks for the comment @sadanand48 
   
   I believe that the cache entries are always cleared during each double 
buffer flush, which means that eventually, everything must be written to the 
database at some point in time, correct? Or is there a possibility that 
something might be left behind in the cache? 
   Please correct me if I am going wrong somewhere!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to