sodonnel commented on code in PR #5678:
URL: https://github.com/apache/ozone/pull/5678#discussion_r1406106400
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/RatisContainerReplicaCount.java:
##########
@@ -566,8 +566,7 @@ public boolean isSafelyOverReplicated() {
return false;
}
- return getMatchingReplicaCount() >= repFactor &&
- getMatchingReplicaCount() - repFactor >= inFlightDel;
+ return getMatchingReplicaCount() >= repFactor;
Review Comment:
I think the javadoc needs updated since you have change the criteria here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
