siddhantsangwan commented on PR #5678: URL: https://github.com/apache/ozone/pull/5678#issuecomment-1831210001
> @siddhantsangwan `TestReplicationManager` is passing with your code ([siddhantsangwan@757b079](https://github.com/siddhantsangwan/ozone/commit/757b0797df502c2000520090e35ce278662e9e2a)). However, PRs test code as it would be after being merged into `master`. In that state `TestReplicationManager` is failing. To reproduce, just merge `master` into your branch locally. @adoroszlai Yes, you're right. I was able to reproduce the failing test yesterday locally but @sodonnel and I have been discussing whether the test has the correct expectations at all. `testQuasiClosedContainerWithUnhealthyReplicaOnUniqueOrigin` sets up a `QUASI_CLOSED` container with 3 `QUASI_CLOSED` replicas with the same origin datanode and 1 `UNHEALTHY` replica on a unique origin datanode. It expects a replica other than the unique origin to get deleted. But I'm not sure if we should be deleting anything at all in this case. In fact, if one `QUASI_CLOSED` replica is deleted, RM will see the container as under replicated in the next iteration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
