sodonnel commented on code in PR #5678:
URL: https://github.com/apache/ozone/pull/5678#discussion_r1410624509
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/health/TestRatisUnhealthyReplicationCheckHandler.java:
##########
@@ -366,29 +352,45 @@ public void overReplicationCheckWithQuasiClosedReplica() {
final ContainerInfo container = ReplicationTestUtil.createContainerInfo(
repConfig, 1, HddsProtos.LifeCycleState.CLOSED, sequenceID);
- final Set<ContainerReplica> replicas = new HashSet<>(2);
- replicas.add(createContainerReplica(container.containerID(), 0,
- IN_SERVICE, State.CLOSED, sequenceID));
- replicas.add(createContainerReplica(container.containerID(), 0,
- IN_SERVICE, State.CLOSED, sequenceID));
- replicas.add(createContainerReplica(container.containerID(), 0,
- IN_SERVICE, State.CLOSED, sequenceID));
-
- final ContainerReplica quasiClosedReplica =
- createContainerReplica(container.containerID(), 0,
- IN_SERVICE, State.QUASI_CLOSED, sequenceID - 1);
- replicas.add(quasiClosedReplica);
+ Set<ContainerReplica> replicas = new HashSet<>(4);
+ for (int i = 0; i < 4; i++) {
+ replicas.add(createContainerReplica(container.containerID(), 0,
+ IN_SERVICE, State.QUASI_CLOSED, sequenceID - 1));
Review Comment:
I think this is OK. I was just confirming my understanding really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
