smengcl commented on code in PR #5620:
URL: https://github.com/apache/ozone/pull/5620#discussion_r1411648145
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -166,5 +179,64 @@ public void testMissingContainerDownNode() throws
Exception {
0, 1000);
return (allMissingContainers.isEmpty());
});
+ IOUtils.closeQuietly(client);
+ }
+
+ @Test
+ public void testEmptyMissingContainerDownNode() throws Exception {
Review Comment:
Can we add a comment (short paragraph) describing the overall purpose and
flow of this integration test?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -166,5 +179,64 @@ public void testMissingContainerDownNode() throws
Exception {
0, 1000);
return (allMissingContainers.isEmpty());
});
+ IOUtils.closeQuietly(client);
+ }
+
+ @Test
+ public void testEmptyMissingContainerDownNode() throws Exception {
Review Comment:
Can we add a comment (short paragraph) describing the overall purpose and
flow of this integration test at the beginning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
