smengcl commented on code in PR #5620:
URL: https://github.com/apache/ozone/pull/5620#discussion_r1411654435
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java:
##########
@@ -312,17 +380,37 @@ public static List<UnhealthyContainers>
generateUnhealthyRecords(
*/
public static List<UnhealthyContainers> generateUnhealthyRecords(
ContainerHealthStatus container, Set<String> recordForStateExists,
- long time) {
+ long time,
+ Map<String, Map<String, Long>> unhealthyContainerStateStatsMap) {
List<UnhealthyContainers> records = new ArrayList<>();
if (container.isHealthy() || container.isDeleted()) {
return records;
}
if (container.isMissing()
&& !recordForStateExists.contains(
- UnHealthyContainerStates.MISSING.toString())) {
- records.add(
- recordForState(container, UnHealthyContainerStates.MISSING, time));
+ UnHealthyContainerStates.MISSING.toString())) {
+ if (!container.isEmpty()) {
+ LOG.info("Container is missing but not empty, mapped with {} " +
+ "number of keys and having {} usedBytes in SCM metadata. " +
+ "For all OM keys mapped to this container, pls check the " +
+ "missing container page in Recon which shows all the keys " +
+ "and their metadata.", container.getNumKeys(),
+ container.getContainer().getUsedBytes());
Review Comment:
```suggestion
LOG.info("Non-empty container {} is missing. It has {} " +
"keys and {} bytes used according to SCM metadata. " +
"Please visit Recon's missing container page for more " +
"details (list of keys and their metadata).",
container.getContainerID(), container.getNumKeys(),
container.getContainer().getUsedBytes());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
