smengcl commented on code in PR #5620:
URL: https://github.com/apache/ozone/pull/5620#discussion_r1411663859


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java:
##########
@@ -100,42 +111,89 @@ public void run() {
 
   public void triggerContainerHealthCheck() {
     lock.writeLock().lock();
+    Map<String, Map<String, Long>> unhealthyContainerStateStatsMap;

Review Comment:
   Also consider using enum directly rather than converting it to `String` for 
the key `unhealthyState`.
   
   ```suggestion
           Map<UnHealthyContainerStates, Map<String, Long>>
               unhealthyContainerStateStatsMap) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to