devmadhuu commented on code in PR #5620:
URL: https://github.com/apache/ozone/pull/5620#discussion_r1412302576
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -166,5 +179,64 @@ public void testMissingContainerDownNode() throws
Exception {
0, 1000);
return (allMissingContainers.isEmpty());
});
+ IOUtils.closeQuietly(client);
+ }
+
+ @Test
+ public void testEmptyMissingContainerDownNode() throws Exception {
Review Comment:
Done.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -166,5 +179,64 @@ public void testMissingContainerDownNode() throws
Exception {
0, 1000);
return (allMissingContainers.isEmpty());
});
+ IOUtils.closeQuietly(client);
+ }
+
+ @Test
+ public void testEmptyMissingContainerDownNode() throws Exception {
+ ReconStorageContainerManagerFacade reconScm =
+ (ReconStorageContainerManagerFacade)
+ cluster.getReconServer().getReconStorageContainerManager();
+
+ StorageContainerManager scm = cluster.getStorageContainerManager();
+ PipelineManager reconPipelineManager = reconScm.getPipelineManager();
+ PipelineManager scmPipelineManager = scm.getPipelineManager();
+
+ // Make sure Recon's pipeline state is initialized.
+ LambdaTestUtils.await(60000, 5000,
+ () -> (reconPipelineManager.getPipelines().size() >= 1));
+
+ ContainerManager scmContainerManager = scm.getContainerManager();
+ ReconContainerManager reconContainerManager =
+ (ReconContainerManager) reconScm.getContainerManager();
+ ContainerInfo containerInfo =
+ scmContainerManager
+ .allocateContainer(RatisReplicationConfig.getInstance(ONE),
"test");
+ long containerID = containerInfo.getContainerID();
+
+ Pipeline pipeline =
+ scmPipelineManager.getPipeline(containerInfo.getPipelineID());
+ XceiverClientGrpc client = new XceiverClientGrpc(pipeline, conf);
+ runTestOzoneContainerViaDataNode(containerID, client);
+
+ // Make sure Recon got the container report with new container.
+ assertEquals(scmContainerManager.getContainers(),
+ reconContainerManager.getContainers());
+
+ // Bring down the Datanode that had the container replica.
+ cluster.shutdownHddsDatanode(pipeline.getFirstNode());
+
+ LambdaTestUtils.await(120000, 6000, () -> {
+ List<UnhealthyContainers> allMissingContainers =
+ reconContainerManager.getContainerSchemaManager()
+ .getUnhealthyContainers(
+ ContainerSchemaDefinition.UnHealthyContainerStates.
+ EMPTY_MISSING,
+ 0, 1000);
+ return (allMissingContainers.size() == 1);
+ });
+
+ // Restart the Datanode to make sure we remove the missing container.
+ cluster.restartHddsDatanode(pipeline.getFirstNode(), true);
+ LambdaTestUtils.await(120000, 6000, () -> {
Review Comment:
Done as suggested. Reduced to 1s.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -166,5 +179,64 @@ public void testMissingContainerDownNode() throws
Exception {
0, 1000);
return (allMissingContainers.isEmpty());
});
+ IOUtils.closeQuietly(client);
+ }
+
+ @Test
+ public void testEmptyMissingContainerDownNode() throws Exception {
+ ReconStorageContainerManagerFacade reconScm =
+ (ReconStorageContainerManagerFacade)
+ cluster.getReconServer().getReconStorageContainerManager();
+
+ StorageContainerManager scm = cluster.getStorageContainerManager();
+ PipelineManager reconPipelineManager = reconScm.getPipelineManager();
+ PipelineManager scmPipelineManager = scm.getPipelineManager();
+
+ // Make sure Recon's pipeline state is initialized.
+ LambdaTestUtils.await(60000, 5000,
+ () -> (reconPipelineManager.getPipelines().size() >= 1));
+
+ ContainerManager scmContainerManager = scm.getContainerManager();
+ ReconContainerManager reconContainerManager =
+ (ReconContainerManager) reconScm.getContainerManager();
+ ContainerInfo containerInfo =
+ scmContainerManager
+ .allocateContainer(RatisReplicationConfig.getInstance(ONE),
"test");
+ long containerID = containerInfo.getContainerID();
+
+ Pipeline pipeline =
+ scmPipelineManager.getPipeline(containerInfo.getPipelineID());
+ XceiverClientGrpc client = new XceiverClientGrpc(pipeline, conf);
+ runTestOzoneContainerViaDataNode(containerID, client);
+
+ // Make sure Recon got the container report with new container.
+ assertEquals(scmContainerManager.getContainers(),
+ reconContainerManager.getContainers());
+
+ // Bring down the Datanode that had the container replica.
+ cluster.shutdownHddsDatanode(pipeline.getFirstNode());
+
+ LambdaTestUtils.await(120000, 6000, () -> {
Review Comment:
Done as suggested. Reduced to 1s.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -166,5 +179,64 @@ public void testMissingContainerDownNode() throws
Exception {
0, 1000);
return (allMissingContainers.isEmpty());
});
+ IOUtils.closeQuietly(client);
+ }
+
+ @Test
+ public void testEmptyMissingContainerDownNode() throws Exception {
+ ReconStorageContainerManagerFacade reconScm =
+ (ReconStorageContainerManagerFacade)
+ cluster.getReconServer().getReconStorageContainerManager();
+
+ StorageContainerManager scm = cluster.getStorageContainerManager();
+ PipelineManager reconPipelineManager = reconScm.getPipelineManager();
+ PipelineManager scmPipelineManager = scm.getPipelineManager();
+
+ // Make sure Recon's pipeline state is initialized.
+ LambdaTestUtils.await(60000, 5000,
Review Comment:
Thanks @smengcl for review. Done as suggested. Reduced to 1s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
