smengcl commented on code in PR #5620:
URL: https://github.com/apache/ozone/pull/5620#discussion_r1411673716
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java:
##########
@@ -100,42 +111,89 @@ public void run() {
public void triggerContainerHealthCheck() {
lock.writeLock().lock();
+ Map<String, Map<String, Long>> unhealthyContainerStateStatsMap;
try {
+ unhealthyContainerStateStatsMap = new HashMap<>(Collections.emptyMap());
+ initializeUnhealthyContainerStateStatsMap(
+ unhealthyContainerStateStatsMap);
long start = Time.monotonicNow();
long currentTime = System.currentTimeMillis();
- long existingCount = processExistingDBRecords(currentTime);
+ long existingCount = processExistingDBRecords(currentTime,
+ unhealthyContainerStateStatsMap);
LOG.info("Container Health task thread took {} milliseconds to" +
" process {} existing database records.",
Time.monotonicNow() - start, existingCount);
start = Time.monotonicNow();
final List<ContainerInfo> containers = containerManager.getContainers();
containers.stream()
.filter(c -> !processedContainers.contains(c))
- .forEach(c -> processContainer(c, currentTime));
+ .forEach(c -> processContainer(c, currentTime,
+ unhealthyContainerStateStatsMap));
Review Comment:
Unrelated to this PR but this `containerManager.getContainers()` is not
using the API with pagination right now. Should this pose any memory issue
(e.g. OOM) we should improve this. Ideally, the pagination logic can be hidden
inside an `Iterator` just like `OzoneBucket#listKeys`.
Could you file a jira for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
