ashishkumar50 commented on code in PR #5847:
URL: https://github.com/apache/ozone/pull/5847#discussion_r1444807149
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java:
##########
@@ -156,17 +160,17 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager();
- boolean isHSync = commitKeyRequest.hasHsync() &&
- commitKeyRequest.getHsync();
-
- if (isHSync) {
+ boolean isHSync = commitKeyRequest.hasHsync() &&
commitKeyRequest.getHsync();
+ boolean isRecovery = commitKeyRequest.hasRecovery() &&
commitKeyRequest.getRecovery();
+ boolean realCommit = (!isHSync) || (isHSync && isRecovery);
Review Comment:
I see it's changed now.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMRecoverLeaseRequest.java:
##########
@@ -186,60 +179,56 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
return omClientResponse;
}
- private String doWork(OzoneManager ozoneManager, long transactionLogIndex)
- throws IOException {
-
+ private RecoverLeaseResponse doWork(OzoneManager ozoneManager,
Review Comment:
Yes makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
