ChenSammi commented on code in PR #5847:
URL: https://github.com/apache/ozone/pull/5847#discussion_r1442427277
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/OMRequestTestUtils.java:
##########
@@ -1571,7 +1571,7 @@ public static long addParentsToDirTable(String
volumeName, String bucketName,
OMRequestTestUtils.createOmDirectoryInfo(pathElement, ++objectId,
parentId);
OMRequestTestUtils.addDirKeyToDirTable(true, omDirInfo,
- volumeName, bucketName, txnID, omMetaMgr);
+ volumeName, bucketName, ++txnID, omMetaMgr);
Review Comment:
From txn ID point of view, ID should be different for every update
operation. Although here in the test, previous same ID doesn't cause any
problem since it's not checked in the test. But if later, some new tests start
to check the ID, then they will have problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
