ChenSammi commented on code in PR #5847:
URL: https://github.com/apache/ozone/pull/5847#discussion_r1442421035
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -660,6 +662,25 @@ protected OmBucketInfo getBucketInfo(OMMetadataManager
omMetadataManager,
return value != null ? value.getCacheValue() : null;
}
+ @NotNull
Review Comment:
This can move back. It's move in the first implementation edition where the
key commit is called from OMRecoverLeaseRequest. Later I found the key commit
in OMRecoverLeaseRequest missed to handle many thing, such as bucket quota
check, bucket used bytes update, reallocated but not used block release. All
these are already addressed in OMKeyCommitRequestWithFSO. So use
OMKeyCommitRequestWithFSO to do the final key commit is a better way than
commit in OMRecoverLeaseRequest. That's current edition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
