hemantk-12 commented on code in PR #5970:
URL: https://github.com/apache/ozone/pull/5970#discussion_r1447937609
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ListIterator.java:
##########
@@ -118,13 +120,16 @@ public static class DbTableIter<Value> implements
private final Table<String, Value> table;
private HeapEntry currentKey;
+ private Predicate<String> isKeyExistsInCache;
Review Comment:
```suggestion
private Predicate<String> isKeyExistInCache;
```
nit: may be name is `doesKeyExistInCache`.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ListIterator.java:
##########
@@ -321,7 +332,9 @@ public boolean hasNext() {
return !minHeap.isEmpty();
}
- public HeapEntry next() {
+ // HeapEntry can be null when a key is marked as deleted because
Review Comment:
I didn't quite get this comment. Does it mean for deleted entries cache will
have null value? If that's the case, I think better approach would be to filter
it out when populating CacheIter in `populateCacheMap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
