sumitagrawl commented on code in PR #5970:
URL: https://github.com/apache/ozone/pull/5970#discussion_r1448464239
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ListIterator.java:
##########
@@ -144,7 +149,7 @@ private void getNextKey() throws IOException {
while (tableIterator.hasNext() && currentKey == null) {
Table.KeyValue<String, Value> entry = tableIterator.next();
String entryKey = entry.getKey();
- if (!KeyManagerImpl.isKeyInCache(entryKey, table)) {
+ if (!isKeyExistsInCache.test(entryKey)) {
Review Comment:
seems some problem in implementation of DBTableIterator,
- hasNext() moves to next key by calling getNextKey()
- next() also call hasNext() implicitly calling getNextKey() and moves to
next key
So while iterator, element can move twice skipping entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
