fapifta opened a new pull request, #6136:
URL: https://github.com/apache/ozone/pull/6136

   ## What changes were proposed in this pull request?
   Removing dead code from hdds-common module. Dead code, besides that it is 
not used, can be harmful if someone starts to use it, as it was not used it 
might not have been updated either along with similar functionality, so it is 
better to get rid of it.
   
   Please describe your PR in detail:
   The PR is, removing unused code from hdds-common module. There are still 
things that are not referenced anywhere in the project and remains in the code 
after this PR, as removing them are not trivial. Majority of these cases are 
configuration related constants and some methods for which I was not 
comfortable removing them right now without more involved thinking.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-10249
   
   ## How was this patch tested?
   Functionality should not be changing, if the code compiles, and existing 
tests are running fine, that pretty much proves that we did not needed these 
methods.
   On the other hand, due to potential reflective access it is hard to prove 
that complete methods are not called, therefore I ran a search for the method 
name in the codebase and checked for that manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to