adoroszlai commented on PR #6136: URL: https://github.com/apache/ozone/pull/6136#issuecomment-1920855815
Thanks @fapifta for your efforts to clean up code. I support cleanup in general, but I have the following concerns: 1. I think we should first discuss what kind of code is OK to remove. E.g. should we consider compatibility when changing public interfaces? Maybe some code should be removed in two steps: deprecate first, remove in next release. We may also want to add `@InterfaceAudience` consistently. 2. It would be nice to tag folks who added code being removed. Maybe they had some future plans. (I doubt that's the case in most cases, but it doesn't hurt to double-check.) 3. To accommodate contributors from all time zones, please give at least 24 hours for feedback before merging non-trivial PRs. To avoid blocking your cleanup effort unnecessarily, I think it may be best to group changes into multiple PRs based on complexity/severity instead of modules. (We can get rid of unused `private` code more easily.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
