fapifta commented on code in PR #6136:
URL: https://github.com/apache/ozone/pull/6136#discussion_r1474029674


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/exception/CertificateException.java:
##########
@@ -88,7 +88,6 @@ public enum ErrorCode {
     BOOTSTRAP_ERROR,
     CSR_ERROR,
     CRYPTO_SIGNATURE_VERIFICATION_ERROR,
-    CERTIFICATE_NOT_FOUND_ERROR,

Review Comment:
   About this one I am pretty sure it does not go through any protocol or 
conversion during runtime.
   We have a couple other similar ErrorCode enums for different exceptions, I 
left those as they are for now, because I felt that if I want to be sure then I 
need a bit more involved lookup for how the exception is used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to