adoroszlai commented on code in PR #6187:
URL: https://github.com/apache/ozone/pull/6187#discussion_r1481203419


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -36,8 +36,8 @@
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
 public final class OzoneConfigKeys {
-  public static final String DFS_CONTAINER_IPC_PORT =
-      "dfs.container.ipc";
+  public static final String OZONE_CONTAINER_IPC_PORT =
+      "ozone.container.ipc.port";

Review Comment:
   To reduce the size of the patch, I suggest renaming items in two steps:
   
   1. config keys (`dfs.container.ipc` to `ozone.container.ipc.port`)
   2. java constants (`DFS_CONTAINER_IPC_PORT` to `OZONE_CONTAINER_IPC_PORT`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to