adoroszlai commented on PR #6187: URL: https://github.com/apache/ozone/pull/6187#issuecomment-1933760792
To clarify my comment about separating changes: it's not just about the size of the patch itself. Renaming config keys is a relatively small change, focused on a few files, but it must be well tested to ensure compatibility. On the other hand, renaming constants is a massive, but simple change, affecting ~50 files in this case. Yet, regular CI checks are enough as a test; it should be fine as long as code compiles and checkstyle is happy. This part of the change is likely to cause merge conflicts for other PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
