sarvekshayr commented on PR #6187: URL: https://github.com/apache/ozone/pull/6187#issuecomment-1933738707
> Thanks @sarvekshayr for updating the patch. > > There are a few config keys with `dfs.` prefix left. Probably the list in the Jira issue is outdated. > > ``` > hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java > 54: = "dfs.container.ratis.num.write.chunk.threads.per.volume"; > 82: "dfs.container.ratis.statemachinedata.sync.retries"; > 85: "dfs.container.ratis.statemachine.max.pending.apply-transactions"; > 92: "dfs.container.ratis.log.queue.num-elements"; > 96: "dfs.container.ratis.log.queue.byte-limit"; > 101: "dfs.container.ratis.log.appender.queue.num-elements"; > 105: "dfs.container.ratis.log.appender.queue.byte-limit"; > 109: "dfs.container.ratis.log.purge.gap"; > 114: "dfs.container.ratis.leader.pending.bytes.limit"; > 119: "dfs.ratis.server.retry-cache.timeout.duration"; > > hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java > 68: "dfs.container.ratis.datastream.random.port"; > 74: "dfs.container.chunk.write.sync"; > 86: "dfs.container.ratis.admin.port"; > 92: "dfs.container.ratis.server.port"; > 99: = "dfs.container.ratis.datastream.enabled"; > 103: = "dfs.container.ratis.datastream.port"; > ``` > > Also, Java constants for default values of the renamed config keys still use the old `DFS_` prefix. It would be nice to match names for key and default value. Example: > > https://github.com/apache/ozone/blob/2cbabcc090dc6f78b0af8c4221c777b550bdc92b/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java#L79-L81 Sure! I'll rename the remaining ones as well. I'll create a sub-task to do the same in order to reduce the size of this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
