smengcl commented on code in PR #6155:
URL: https://github.com/apache/ozone/pull/6155#discussion_r1481482754
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -125,6 +125,9 @@ public class HddsDatanodeService extends GenericCli
implements ServicePlugin {
private HddsDatanodeClientProtocolServer clientProtocolServer;
private OzoneAdmins admins;
private ReconfigurationHandler reconfigurationHandler;
+ // Default datanode initial and current version to be used when datanode.id
file doesn't exist
+ // Note: Currently this is only used in tests.
+ private int defaultInitialVersion = -1, defaultCurrentVersion = -1;
Review Comment:
Thanks @adoroszlai .
I wanted to allow different datanodes to have different initial and current
version for testing. Mockito can't seem to return different values for each
instance.
I have switched to the approach you suggested for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
