smengcl commented on code in PR #6155:
URL: https://github.com/apache/ozone/pull/6155#discussion_r1482033772
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -45,6 +45,8 @@ message DatanodeDetailsProto {
optional string networkLocation = 7; // Network topology location
optional NodeOperationalState persistedOpState = 8; // The Operational
state persisted in the datanode.id file
optional int64 persistedOpStateExpiry = 9; // The seconds after the epoch
when the OpState should expire
+ optional int32 initialVersion = 10; // Initial datanode version. TODO:
This is not useful for clients and can be ignored.
Review Comment:
@adoroszlai Ah, I forgot to ask. Do you think we even need to pass
`initialVersion` to the client?
It was only used by DN itself (HDDS-4730). Now for HDDS-9752 we only need
`currentVersion`, but not `initialVersion`.
Or do we just want to pass both for cleanliness? which is what I have here
in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
