smengcl commented on code in PR #6155:
URL: https://github.com/apache/ozone/pull/6155#discussion_r1481492571
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -125,6 +125,9 @@ public class HddsDatanodeService extends GenericCli
implements ServicePlugin {
private HddsDatanodeClientProtocolServer clientProtocolServer;
private OzoneAdmins admins;
private ReconfigurationHandler reconfigurationHandler;
+ // Default datanode initial and current version to be used when datanode.id
file doesn't exist
+ // Note: Currently this is only used in tests.
+ private int defaultInitialVersion = -1, defaultCurrentVersion = -1;
Review Comment:
Another approach that I thought about even before adding these two new
fields is to create custom datanode.id file for each DN before they boot up.
With this, `getDatanodeIdFilePath()` would parse datanode.id for each and will
be able to have simulate DNs with different initial/current versions. But I
considered that too hacky than the new fields approach so I didn't go that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
