smengcl commented on PR #6155: URL: https://github.com/apache/ozone/pull/6155#issuecomment-1942224226
> Can this information be deduced from the Service Info that the client establishes? Unless we want mixed version Datanodes (mixed set of Datanodes finalized post upgrade), I don't see why we need to add more load to the protocol executed for every read. @kerneltime Do you mean [`ServiceInfo`](https://github.com/apache/ozone/blob/cfb8bae20bd79f3eafa82f5059854096c78e9ead/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/ServiceInfo.java#L39)? It doesn't seem to convey DN version but rather `OzoneManagerVersion` only. Also on the DN side, `DatanodeVersion` differs from `HDDSLayoutFeature` in that `DatanodeVersion` is the (RPC) version over wire, while `HDDSLayoutFeature` is the DN layout version on disk. I currently do not see another way of telling the client that the DN is using a newer version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
