errose28 commented on code in PR #6155:
URL: https://github.com/apache/ozone/pull/6155#discussion_r1486692004
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -425,14 +424,15 @@ private DatanodeDetails initializeDatanodeDetails()
Preconditions.checkNotNull(idFilePath);
File idFile = new File(idFilePath);
if (idFile.exists()) {
- return ContainerUtils.readDatanodeDetailsFrom(idFile);
+ DatanodeDetails details = ContainerUtils.readDatanodeDetailsFrom(idFile);
+ details.setCurrentVersion(DatanodeVersion.CURRENT_VERSION);
Review Comment:
The current and initial versions should already be set in
`ContainerUtils#readDatanodeDetailsFrom`
[here](https://github.com/apache/ozone/blob/54a5a3c59ce450f81d71d8412fcebbd334d2a59e/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java#L116-L117)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
