jojochuang commented on code in PR #6155:
URL: https://github.com/apache/ozone/pull/6155#discussion_r1490258761
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java:
##########
@@ -132,12 +135,14 @@ public class MiniOzoneClusterImpl implements
MiniOzoneCluster {
private CertificateClient caClient;
private final Set<AutoCloseable> clients = ConcurrentHashMap.newKeySet();
private SecretKeyClient secretKeyClient;
+ private static MockedStatic mockDNStatic =
Mockito.mockStatic(HddsDatanodeService.class);
Review Comment:
this doc https://www.baeldung.com/mockito-mock-static-methods
recommends to enclose MockedStatic in a try block to avoid side effects that
impacts other tests.
I think it's fine for this case though because we usually just have one mini
cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
