errose28 commented on code in PR #6245:
URL: https://github.com/apache/ozone/pull/6245#discussion_r1500047408
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java:
##########
@@ -85,7 +85,7 @@ public abstract class TestOzoneManagerHA {
/* Reduce max number of retries to speed up unit test. */
private static final int OZONE_CLIENT_FAILOVER_MAX_ATTEMPTS = 5;
private static final int IPC_CLIENT_CONNECT_MAX_RETRIES = 4;
- private static final long SNAPSHOT_THRESHOLD = 50;
+ private static final long SNAPSHOT_THRESHOLD = 1;
Review Comment:
Setting this globally may mask other problems in prepare or other OM HA
tests when snapshots are *not* taken. We should probably only set in the one
new test.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/upgrade/OMPrepareRequest.java:
##########
@@ -212,12 +212,6 @@ private static long waitForLogIndex(long minOMDBFlushIndex,
"OM database flushed index %d which is less than the minimum " +
"required index %d.",
flushTimeout.getSeconds(), lastOMDBFlushIndex, minOMDBFlushIndex));
- } else if (!ratisStateMachineApplied) {
- throw new IOException(String.format("After waiting for %d seconds, " +
- "Ratis state machine applied index %d which is less than" +
- " the minimum required index %d.",
- flushTimeout.getSeconds(), lastRatisCommitIndex,
- minRatisStateMachineIndex));
Review Comment:
We should remove `minRatisStateMachineIndex` and `ratisStateMachineApplied`
from the other parts of this function as well if we are no longer using them.
We also need to make sure that `om.getRatisSnapshotIndex()` returning an index
means that was actually written to RocksDB. Checking the transaction info table
may be a better option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
