smengcl commented on PR #6285: URL: https://github.com/apache/ozone/pull/6285#issuecomment-1970041867
> @smengcl , thanks for working on this! The change looks good. How about move the `nodesInOrder` to a new class? See [issues.apache.org/jira/secure/attachment/13067089/6285_review.patch](https://issues.apache.org/jira/secure/attachment/13067089/6285_review.patch) Good idea! Thanks. That makes the code much cleaner. Great use of `Collections.unmodifiableList()` as well. Waiting for CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
