duongkame commented on PR #6285: URL: https://github.com/apache/ozone/pull/6285#issuecomment-1972244719
Adding synchronized to `getProtobufMessage` surely impacts OM performance in case there's a hot Pipeline. E.g. many concurrent reads to the same keys, or keys in the same container. A few thought: - If it's caused by [HDDS-9848](https://issues.apache.org/jira/browse/HDDS-9848)? Why not just revert it? - Can we do it another way? I.g. favor immutabily/copy instead of changing the same instance? - Use ReadWriteLock instead of synchronization? @smengcl @kerneltime -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
