smengcl commented on PR #6285: URL: https://github.com/apache/ozone/pull/6285#issuecomment-1972355206
Thanks @duongkame for the comment. > * If it's caused by [HDDS-9848](https://issues.apache.org/jira/browse/HDDS-9848)? Why not just revert it? Because the whole point of HDDS-9848 is to share `nodesInOrder` among threads. > * Can we do it another way? I.g. favor immutabily/copy instead of changing the same instance? > * Use ReadWriteLock instead of synchronization? I feel like if we need to get rid the lock (whether intrinsic or reentrant) here we may need to reconsider the design here, e.g. why do we need to sort this DN list every now and then. The goal of this PR is to fix the bug first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
