smengcl opened a new pull request, #6413:
URL: https://github.com/apache/ozone/pull/6413
WIP. Re-targeting feature branch to facilitate easier testing with other
hsync/hbase related changes and improvements.
## What changes were proposed in this pull request?
`synchronized` keyword has been added to write/hsync methods in HDDS-7907 to
ensure correctness. But it is deemed to reduce write/hsync throughput at this
point.
This PR aims to reduce blocking by immediately returning the future rather
than waiting on it to return to allow write/hsync to interleave while ensuring
correctness. (Submit the request and return immediately.) This inevitably
involves some refactoring.
- [ ] Resolve `testConcurrentWriteHSync` failure:
```
java.io.IOException: java.lang.NullPointerException: Future not found for
16384: existing = [32768, 1, 65536]
at
org.apache.hadoop.ozone.client.io.KeyOutputStream.handleWrite(KeyOutputStream.java:246)
at
org.apache.hadoop.ozone.client.io.KeyOutputStream.write(KeyOutputStream.java:211)
at
org.apache.hadoop.ozone.client.io.OzoneOutputStream.write(OzoneOutputStream.java:94)
at
org.apache.hadoop.fs.ozone.OzoneFSOutputStream.write(OzoneFSOutputStream.java:50)
at
org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:62)
at java.io.DataOutputStream.write(DataOutputStream.java:107)
at java.io.FilterOutputStream.write(FilterOutputStream.java:97)
at
org.apache.hadoop.fs.ozone.TestHSync.lambda$runConcurrentWriteHSync$5(TestHSync.java:577)
```
- [ ] Finish error handling migration.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9844
## How was this patch tested?
- [ ] All existing tests covering key stream write/hsync/close must pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
