jojochuang commented on code in PR #6413: URL: https://github.com/apache/ozone/pull/6413#discussion_r1542197196
########## hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/NonBlockingSyncable.java: ########## @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.storage; + +import java.io.IOException; +import java.util.concurrent.CompletableFuture; + +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; + +/** + * This is the interface for non-blocking flush/sync operations. + * Consult the Hadoop filesystem specification for the definition of the + * semantics of these operations. + */ [email protected] [email protected] +public interface NonBlockingSyncable { + + /** Flush out the data in client's user buffer. After the return of + * this call, new readers will see the data. Review Comment: After the future completes, new readers will see the data. ########## hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/NonBlockingSyncable.java: ########## @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.storage; + +import java.io.IOException; +import java.util.concurrent.CompletableFuture; + +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; + +/** + * This is the interface for non-blocking flush/sync operations. + * Consult the Hadoop filesystem specification for the definition of the + * semantics of these operations. + */ [email protected] [email protected] +public interface NonBlockingSyncable { + + /** Flush out the data in client's user buffer. After the return of + * this call, new readers will see the data. + * @throws IOException if any error occurs + */ + CompletableFuture<Void> hflush() throws IOException; + + /** Similar to posix fsync, flush out the data in client's user buffer Review Comment: Similar to posix fsync but instead of a blocking call, it returns a CompletableFuture. ########## hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java: ########## @@ -432,9 +463,17 @@ protected boolean checkIfContainerToExclude(Throwable t) { } @Override - public synchronized void flush() throws IOException { + public synchronized void flush() throws IOException { // TODO: Remove synchronized Review Comment: we need to get rid of this synchronized block. HBase WAL writer does a flush() followed by hsync(). ########## hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/NonBlockingSyncable.java: ########## @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.storage; + +import java.io.IOException; +import java.util.concurrent.CompletableFuture; + +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; + +/** + * This is the interface for non-blocking flush/sync operations. + * Consult the Hadoop filesystem specification for the definition of the + * semantics of these operations. + */ [email protected] Review Comment: should it be a public API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
